apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

fix: tmp is not writable on sandboxed environment

Open butterfly1924 opened this issue 2 years ago • 2 comments

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request? When building on Android termux environment, tmp is mounted as read-only volume, this pr fixes the download error on make build.

  • [x] Bugfix
  • [ ] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #0001

Checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [ ] Have you added corresponding test cases?
  • [ ] Have you modified the corresponding document?
  • [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

butterfly1924 avatar Jul 25 '22 13:07 butterfly1924

Codecov Report

Merging #2542 (4e5fdef) into master (1a7f291) will decrease coverage by 3.59%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
- Coverage   68.58%   64.98%   -3.60%     
==========================================
  Files         133       61      -72     
  Lines        3501     3975     +474     
  Branches      861        0     -861     
==========================================
+ Hits         2401     2583     +182     
+ Misses       1100     1033      -67     
- Partials        0      359     +359     
Flag Coverage Δ
backend-e2e-test-ginkgo 64.98% <ø> (?)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/transform.ts
web/src/pages/Setting/Setting.tsx
web/src/hooks/usePagination.ts
...tream/components/active-check/Healthy/Interval.tsx
web/src/components/Upstream/components/Nodes.tsx
web/src/components/Upstream/UpstreamForm.tsx
web/src/components/Plugin/data.tsx
...eb/src/components/Upstream/components/PassHost.tsx
web/src/components/RawDataEditor/RawDataEditor.tsx
...rc/components/Upstream/components/RetryTimeout.tsx
... and 184 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov-commenter avatar Jul 25 '22 14:07 codecov-commenter

Why need to build on Android termux?

Baoyuantop avatar Jul 28 '22 01:07 Baoyuantop