apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

Feature request: support regex_uri attribute in redirect plugin

Open dogrod opened this issue 2 years ago • 8 comments

Feature request

Please describe your feature

image

APISIX already supports uri attribute in redirect plugin, which is under "custom" option in "Name And Description" section. But in some more complex situations, regex_uri would be a better way.

Describe the solution you'd like

image

Add regex_uri support just like the proxy_rewrite plugin.

dogrod avatar Apr 19 '22 02:04 dogrod

Hi @dogrod, thank you for your report. Would you like to help improve this feature?

Baoyuantop avatar Apr 20 '22 01:04 Baoyuantop

ping @hanzhenfang Are you interested in completing it?

guoqqqi avatar May 06 '22 02:05 guoqqqi

let me try.

hanzhenfang avatar May 06 '22 03:05 hanzhenfang

I'm completing it, should I change the Redirect from the select to a radio, or add a new option on the original basis?

hqh15 avatar Aug 02 '22 06:08 hqh15

I'm completing it, should I change the Redirect from the select to a radio, or add a new option on the original basis?

hello, that's too abstract, can you add a diagram to show what you think?

guoqqqi avatar Aug 03 '22 01:08 guoqqqi

I'm completing it, should I change the Redirect from the select to a radio, or add a new option on the original basis?

hello, that's too abstract, can you add a diagram to show what you think? 1.select image image

2.radio, like this image

hqh15 avatar Aug 03 '22 05:08 hqh15

hi, @Sh1-5 I prefer the latter. When we select Custom, we can add two radio configurations, one for uri by default and one for regex_uri. you can refer to redirect , Looking forward to your PR~

guoqqqi avatar Aug 03 '22 06:08 guoqqqi

hi, @Sh1-5 I prefer the latter. When we select Custom, we can add two radio configurations, one for uri by default and one for regex_uri. you can refer to redirect , Looking forward to your PR~

ok, I have completed it.It's time to write the test case

hqh15 avatar Aug 03 '22 11:08 hqh15