apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

fix: The bug of missing secret field and algorithm when creating jwt-auth has been solved

Open kingmouse-yx opened this issue 2 years ago • 2 comments

…empty, it will be assigned as HS256. If the secret is empty, a secret will be automatically generated.

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • [x] Bugfix
  • [ ] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What changes will this PR take into?

The bug of missing secret field and algorithm when creating jwt-auth has been solved

Related issues

resolve #2384

Checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [x] Have you added corresponding test cases?
  • [x] Have you modified the corresponding document?
  • [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

kingmouse-yx avatar Mar 17 '22 06:03 kingmouse-yx

Codecov Report

Merging #2385 (e17d770) into master (bc13bb9) will decrease coverage by 7.52%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2385      +/-   ##
==========================================
- Coverage   69.79%   62.26%   -7.53%     
==========================================
  Files         188       58     -130     
  Lines        7349     3999    -3350     
  Branches      828        0     -828     
==========================================
- Hits         5129     2490    -2639     
+ Misses       1920     1214     -706     
+ Partials      300      295       -5     
Flag Coverage Δ
backend-e2e-test 36.83% <0.00%> (-0.03%) :arrow_down:
backend-e2e-test-ginkgo ?
backend-unit-test 49.27% <100.00%> (+0.17%) :arrow_up:
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/consumer/consumer.go 93.24% <100.00%> (+1.17%) :arrow_up:
api/internal/core/migrate/conflict.go 0.00% <0.00%> (-80.00%) :arrow_down:
api/internal/core/migrate/migrate.go 0.00% <0.00%> (-76.20%) :arrow_down:
api/internal/core/migrate/dataset.go 0.00% <0.00%> (-53.04%) :arrow_down:
api/internal/handler/migrate/migrate.go 8.06% <0.00%> (-51.62%) :arrow_down:
api/internal/handler/proto/proto.go 23.00% <0.00%> (-44.25%) :arrow_down:
api/internal/handler/healthz/healthz.go 66.66% <0.00%> (-33.34%) :arrow_down:
api/internal/handler/stream_route/stream_route.go 36.36% <0.00%> (-31.17%) :arrow_down:
api/internal/core/store/storehub.go 48.61% <0.00%> (-23.99%) :arrow_down:
api/internal/filter/schema.go 32.80% <0.00%> (-23.21%) :arrow_down:
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc13bb9...e17d770. Read the comment docs.

codecov-commenter avatar Mar 17 '22 06:03 codecov-commenter

Hey, man. Can you resolve this merge conflict?

quanbisen avatar Aug 12 '22 10:08 quanbisen