apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

feat: added dashboard backend api for apisix status summary

Open codewangg opened this issue 4 years ago • 13 comments

Why submit this pull request?

  • [ ] Bugfix
  • [x] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What changes will this PR take into?

added dashboard backend API for apisix status summary

Related issues

The Apache APISIX Dashboard is designed to make it as easy as possible for users to operate Apache APISIX through a frontend interface. Users can manage routes, services, certificates, and other configurations in this dashboard. However, there is currently a lack of an overview page to get the current running time of the dashboard and the number of elements in the dashboard database. The goal of this project is to implement the back-end interface, which is used to obtain the running status of apisix-dashboard, and the number of elements in etcd

Checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [x] Have you added corresponding test cases?
  • [x] Have you modified the corresponding document?
  • [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

codewangg avatar Sep 28 '21 17:09 codewangg

Codecov Report

Merging #2152 (00dd81d) into master (edca223) will decrease coverage by 1.33%. The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2152      +/-   ##
==========================================
- Coverage   70.04%   68.70%   -1.34%     
==========================================
  Files         188      189       +1     
  Lines        7347     7467     +120     
  Branches      828      828              
==========================================
- Hits         5146     5130      -16     
- Misses       1904     2031     +127     
- Partials      297      306       +9     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo 59.98% <84.16%> (+0.56%) :arrow_up:
backend-unit-test 50.06% <75.63%> (+0.95%) :arrow_up:
frontend-e2e-test 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/entity/entity.go 90.90% <ø> (ø)
api/internal/handler/overview/overview.go 86.55% <86.55%> (ø)
api/internal/route.go 87.50% <100.00%> (+0.32%) :arrow_up:
api/internal/handler/data_loader/route_import.go 32.11% <0.00%> (-35.41%) :arrow_down:
api/internal/utils/utils.go 62.00% <0.00%> (-11.00%) :arrow_down:
api/internal/core/storage/etcd.go 47.24% <0.00%> (-6.30%) :arrow_down:
api/internal/core/store/store.go 89.58% <0.00%> (-2.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edca223...00dd81d. Read the comment docs.

codecov-commenter avatar Sep 29 '21 00:09 codecov-commenter

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Dec 07 '21 10:12 github-actions[bot]

Do we still need to implement this feature ? @starsz

zaunist avatar Dec 29 '21 10:12 zaunist

Hi, @codewangg . I see that it has not been updated for a long time, and I will assist you in complete this PR.

zaunist avatar Jan 04 '22 02:01 zaunist

Hi @zaunist , thanks for reaching out, there are still e2e tests needed to be done, please let me know if there's anything I can help with.

codewangg avatar Jan 04 '22 06:01 codewangg

Hi @zaunist , thanks for reaching out, there are still e2e tests needed to be done, please let me know if there's anything I can help with.

Can you add me to the collaborators of the warehouse so that I can submit the code on your PR.

AkIDsM52YR

zaunist avatar Jan 04 '22 06:01 zaunist

Hi Bozhong, thank you for reminding me, I have added you to the collaborators :)

codewangg avatar Jan 10 '22 07:01 codewangg

Hi Bozhong, thank you for reminding me, I have added you to the collaborators :)

Thanks, @codewangg

zaunist avatar Jan 10 '22 07:01 zaunist

@starsz @bzp2010 Please take a look, thanks.

zaunist avatar Mar 14 '22 07:03 zaunist

@starsz @bzp2010 Please take a look, thanks.

Need to set ready for review.

starsz avatar Mar 14 '22 14:03 starsz

@starsz :joy: I can't contact @codewangg. And I don't have the permission to set to review.

zaunist avatar Mar 14 '22 16:03 zaunist

Hi Bozhong, ready to review has been set, I am actively monitoring this stream, so please let me know if there is any other blockage by making new comments.

codewangg avatar Mar 14 '22 16:03 codewangg

Hi Bozhong, ready to review has been set, I am actively monitoring this stream, so please let me know if there is any other blockage by making new comments.

Thanks a lot @codewangg.

zaunist avatar Mar 15 '22 14:03 zaunist