apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

Feature request: support appending query string in redirect plugin

Open liuxiran opened this issue 4 years ago • 7 comments

Feature request

Please describe your feature

Dashboard has integrated the redirect plugin into the first step of Route creation, refer to https://github.com/apache/apisix/pull/4298, it would be better to add append_query_string field

Describe the solution you'd like

liuxiran avatar Aug 26 '21 02:08 liuxiran

This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Nov 06 '21 10:11 github-actions[bot]

Hi @liuxiran @bzp2010 i would like to work on this issue, please assign this to me.

namangirdhar16 avatar Nov 10 '21 10:11 namangirdhar16

Hi, @namangirdhar16 .Did you have any difficulties?

zaunist avatar Dec 16 '21 07:12 zaunist

@zaunist could you help to check this?

juzhiyuan avatar Dec 16 '21 08:12 juzhiyuan

@zaunist could you help to check this?

A great pleasure

zaunist avatar Dec 16 '21 08:12 zaunist

I checked redirect plugin, Only one of http_to_https, uri or regex_uri can be specified., but append_query_string not one of them. So append_query_string maybe a separate button or option menu, because append_query_string can coexist with http_to_https, uri, regex_uri. Is it right ?

zaunist avatar Dec 17 '21 08:12 zaunist

I checked redirect plugin, Only one of http_to_https, uri or regex_uri can be specified., but append_query_string not one of them. So append_query_string maybe a separate button or option menu, because append_query_string can coexist with http_to_https, uri, regex_uri. Is it right ?

Yes, both append_query_string & encode_uri are two seprate buttons, we could use Switch component to handle this.

juzhiyuan avatar Dec 17 '21 09:12 juzhiyuan