ant icon indicating copy to clipboard operation
ant copied to clipboard

Added version and mainClass attributes to <jar> task.

Open craigpell opened this issue 6 years ago • 11 comments

Added version and mainClass attributes to task, to set binary attributes of a modular jar file. For Ant 1.10.x. Addresses these tickets: https://bz.apache.org/bugzilla/show_bug.cgi?id=62772 https://bz.apache.org/bugzilla/show_bug.cgi?id=62789

craigpell avatar Mar 23 '19 18:03 craigpell

Can one of the admins verify this patch?

asfgit avatar Mar 23 '19 18:03 asfgit

Can one of the admins verify this patch?

asfgit avatar Mar 23 '19 18:03 asfgit

Can one of the admins verify this patch?

asfgit avatar Mar 23 '19 18:03 asfgit

Can one of the admins verify this patch?

asfgit avatar Mar 23 '19 18:03 asfgit

this is ok to test

jaikiran avatar Mar 25 '19 02:03 jaikiran

Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/114/

asfgit avatar Mar 25 '19 02:03 asfgit

Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/120/

asfgit avatar Mar 25 '19 02:03 asfgit

Thanks @craigpell, this is a very good enhancement and the code looks very good too. I do have some suggestions/questions about some of the new classes, but I haven't had a chance to fully review this PR. I'll take a more closer look at this one in the next few days and will merge or update this PR with my suggestions/questions.

jaikiran avatar Mar 29 '19 04:03 jaikiran

Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/121/

asfgit avatar Mar 29 '19 04:03 asfgit

Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/115/

asfgit avatar Mar 29 '19 04:03 asfgit

While you are here, a quick suggestion/question - given that these changes are related to Java modules in general and there probably will be more such enhancements for modules, maybe we should rename the newly added org.apache.tools.ant.util.jarattr package to org.apache.tools.ant.util.modules instead? I don't have a strong opinion on it, so if you want to use the current package name that you chose, that's fine by me.

jaikiran avatar Mar 29 '19 04:03 jaikiran