ant icon indicating copy to clipboard operation
ant copied to clipboard

Published 20 hours ago • verified publisher icon apache

Clarify logging

Open twogee opened this issue 3 years ago • 3 comments

twogee avatar Nov 01 '21 12:11 twogee

Hopefully these changes make logging methods a bit more comprehensible. They are backwards binary compatible (according to japicmp 0.15.4).

twogee avatar Nov 02 '21 10:11 twogee

I may have become used to the existing logging setup, but to be honest your proposed change doesn't make anything more comprehensible to me. That may just be me.

bodewig avatar Nov 06 '21 13:11 bodewig

The changes make it clear which objects control logging.

These are DefaultLogger (which currently has a protected log method), Project and ProjectComponent (a superclass of Task, so the latter simply inherits its log method). TraxLiaison sets a Logger, no need for the XSLTLogger.

The next step will be to remove the code duplication discussed in #166 by moving the getMailerImplementation to Mailer and passing a Logger to it.

twogee avatar Nov 07 '21 11:11 twogee