Make final var when is possible.
This is a huge change when it comes to the number of lines touched. When faced with such a big change I always fear I may overlook something subtle.
Personally I don't believe making the argument of a one-line method that just calls another method passing on the argument is improving anything. YMMV.
This is a huge change when it comes to the number of lines touched. When faced with such a big change I always fear I may overlook something subtle.
Personally I don't believe making the argument of a one-line method that just calls another method passing on the argument is improving anything. YMMV.
HI @bodewig I close the PR TY
@arturobernalg I'm by far not the only Ant committer, so please don't feel forced to close a PR just because I comment in an unfavorable way.
@arturobernalg I'm by far not the only Ant committer, so please don't feel forced to close a PR just because I comment in an unfavorable way.
HI @bodewig TY for the feedback. I'll reopen the PR. TY