ant icon indicating copy to clipboard operation
ant copied to clipboard
verified publisher icon apache

Make final var when is possible.

Open arturobernalg opened this issue 4 years ago • 4 comments

arturobernalg avatar Oct 02 '21 19:10 arturobernalg

This is a huge change when it comes to the number of lines touched. When faced with such a big change I always fear I may overlook something subtle.

Personally I don't believe making the argument of a one-line method that just calls another method passing on the argument is improving anything. YMMV.

bodewig avatar Oct 03 '21 11:10 bodewig

This is a huge change when it comes to the number of lines touched. When faced with such a big change I always fear I may overlook something subtle.

Personally I don't believe making the argument of a one-line method that just calls another method passing on the argument is improving anything. YMMV.

HI @bodewig I close the PR TY

arturobernalg avatar Oct 03 '21 11:10 arturobernalg

@arturobernalg I'm by far not the only Ant committer, so please don't feel forced to close a PR just because I comment in an unfavorable way.

bodewig avatar Oct 03 '21 11:10 bodewig

@arturobernalg I'm by far not the only Ant committer, so please don't feel forced to close a PR just because I comment in an unfavorable way.

HI @bodewig TY for the feedback. I'll reopen the PR. TY

arturobernalg avatar Oct 05 '21 16:10 arturobernalg