ant icon indicating copy to clipboard operation
ant copied to clipboard

Published 20 hours ago • verified publisher icon apache

Bugfix/catch dynamic test before each

Open mguillem opened this issue 5 years ago • 4 comments

Ensure that every failed test is reported by the LegacyXmlResultFormatter. Currently failures in @BeforeEach with a @TestFactory are not visible in the XMLreports. Possibly not fully correct classname and name attributes are far better than an invisible failure.

mguillem avatar Mar 03 '20 06:03 mguillem

Hi Ant Team. Can someone provide feedback to this PR? Thanks.

mguillem avatar Mar 23 '20 07:03 mguillem

Hello @mguillem, sorry I just saw this now. Is there a junitreport output that you can show with and without this change? If not, I can test/check this myself in a few days and see how this change then impacts the reports.

jaikiran avatar May 02 '20 11:05 jaikiran

this is ok to test

jaikiran avatar May 02 '20 11:05 jaikiran

@jaikiran do you still need something from me? Failed test seems unrelated to this PR.

mguillem avatar May 15 '20 09:05 mguillem

Hello Marc, sorry this took this long. I saw this PR again this week and what you raise here is a valid bug. I've pushed a commit which should address this and should be available in our upcoming Ant 1.10.14 release.

Please continue to raise any other issues you might see in this task or Ant in general. Sorry again about the delay.

jaikiran avatar Aug 13 '23 16:08 jaikiran