Update AntClassLoader.java

Open majkelBB opened this issue 6 years ago • 6 comments

Shouldn't usage of pathComponents be threadsafe here and in other places where code iterates over pathComponents?

Nov 08 '19 15:11 majkelBB

Can one of the admins verify this patch?

Nov 08 '19 15:11 asf-ci

Can one of the admins verify this patch?

Nov 08 '19 15:11 asf-ci

this is ok to test

Nov 11 '19 04:11 jaikiran

Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/147/

Nov 11 '19 04:11 asf-ci

Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/153/

Nov 11 '19 04:11 asf-ci

The way AntClassLoader wants to be used (and is used inside of Ant's codebase) is a single-threaded setup phase followed by potentially multithreaded use of if where its setup is no longer changed.

Personally I'd rather document this than try to sprinkle in a few synchronizeds.

Nov 11 '19 05:11 bodewig