ant-ivy
ant-ivy copied to clipboard
Ivy main/standalone: Patch to include 'makepom' function
Hello,
I added the pomfile option to main/standalone. This allows creating an (maven) pom file from outside an ant task.
Example of use:
$ pwd
~/.ivy2/cache/org.typelevel/cats-core_2.11
$ java -jar ~/scm/github/ant-ivy/build/artifact/org.apache.ivy_2.5.0.alpha_20180327212209.jar -ivy ivy-1.0.1.xml -pomfile cats-core.xml
$ ls
cats-core-2.11.xml ivy-1.0.1.xml ivy-1.0.1.xml.original ivydata-1.0.1.properties jars srcs
Feedback is welcome. What should I do to get this patch into mainline?
Kind regards,
aanno
@aanno Thank you for the patch. This mostly looks fine. I have added some review comments. Can you please also introduce a test case for this? Something that tests that these command options are recognized and the pom file does get created. There's a MainTest which you can refer to and add a new test method there.
@aanno, thank you for this PR. I have gone ahead and included your patch with minor modifications to upstream and also included a test along with it. I have also included your name in our release notes. Since I couldn't find your full name in your github profile, I used aanno, if you prefer to have your full name included in the release notes, please let me know and I'll update it accordingly.
@aanno could you please rebase and push the branch in order to close the PR?