amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Improvement]: Integrate the Flink table propereties when the Arctic table refresh method is invoked

Open YesOrNo828 opened this issue 3 years ago • 0 comments

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

As of now, the Flink table properties should combine the flink properties and arctic table properties. And the flink properties will replace the same key of the arctic table properties.

tableLoader = ArcticTableLoader.of(PK_TABLE_ID, catalogBuilder);

    tableLoader.open();
    ArcticTable arcticTable = tableLoader.loadArcticTable();

    UpdateProperties updateProperties = arcticTable.updateProperties();
    updateProperties.set(LOG_STORE_CATCH_UP, String.valueOf(LOG_STORE_CATCH_UP_DEFAULT));
    updateProperties.set(LOG_STORE_CATCH_UP_TIMESTAMP, String.valueOf(LOG_STORE_CATCH_UP_TIMESTAMP_DEFAULT));
    updateProperties.commit();

    arcticTable.refresh();
    Map<String, String> properties = arcticTable.properties();
    Assert.assertSame("" + LOG_STORE_CATCH_UP_DEFAULT, properties.get(LOG_STORE_CATCH_UP));
    Assert.assertSame("" + LOG_STORE_CATCH_UP_TIMESTAMP_DEFAULT, properties.get(LOG_STORE_CATCH_UP_TIMESTAMP));

How should we improve?

Add a new proxy method(refresh) of the arctic table in the FlinkTablePropertiesInvocationHandler

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

YesOrNo828 avatar Sep 26 '22 08:09 YesOrNo828