amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-3998]support DATABASE HA SERVICE

Open LiangDai-Mars opened this issue 3 weeks ago • 1 comments

Why are the changes needed?

Please refer to issue https://github.com/apache/amoro/issues/3998.

Brief change log

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

LiangDai-Mars avatar Dec 07 '25 09:12 LiangDai-Mars

Codecov Report

:x: Patch coverage is 13.86555% with 205 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 29.39%. Comparing base (cbdc517) to head (343dce8). :warning: Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...amoro/server/ha/JdbcHighAvailabilityContainer.java 0.00% 134 Missing :warning:
...g/apache/amoro/server/persistence/HaLeaseMeta.java 0.00% 49 Missing :warning:
...ro/server/ha/HighAvailabilityContainerFactory.java 33.33% 7 Missing and 1 partial :warning:
...che/amoro/server/AmoroManagementConfValidator.java 36.36% 5 Missing and 2 partials :warning:
...amoro/server/ha/NoopHighAvailabilityContainer.java 25.00% 6 Missing :warning:
...e/amoro/server/ha/ZkHighAvailabilityContainer.java 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3997      +/-   ##
============================================
+ Coverage     22.12%   29.39%   +7.26%     
- Complexity     2461     3995    +1534     
============================================
  Files           445      643     +198     
  Lines         40897    51647   +10750     
  Branches       5767     6554     +787     
============================================
+ Hits           9050    15181    +6131     
- Misses        31089    35397    +4308     
- Partials        758     1069     +311     
Flag Coverage Δ
core 29.39% <13.86%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 08 '25 10:12 codecov-commenter