amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-3531] Drop support for java8

Open turboFei opened this issue 1 month ago • 8 comments

Why are the changes needed?

Close #3531

This PR removes support for Java 8 across the project. Reasons: Java 8 is end-of-life and no longer receives public updates or security patches. Modern libraries and frameworks increasingly require Java 11+. Dropping Java 8 simplifies code maintenance and allows use of newer language features and APIs. Improves compatibility with current cloud and container environments, which default to Java 11 or higher.

Brief change log

  • Remove GA and deprecate Java8

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

turboFei avatar Nov 05 '25 08:11 turboFei

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 28.94%. Comparing base (17b68d0) to head (a403e20). :warning: Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3899      +/-   ##
============================================
+ Coverage     28.82%   28.94%   +0.11%     
- Complexity     3838     3847       +9     
============================================
  Files           625      631       +6     
  Lines         50514    50722     +208     
  Branches       6455     6496      +41     
============================================
+ Hits          14560    14680     +120     
- Misses        34928    34985      +57     
- Partials       1026     1057      +31     
Flag Coverage Δ
core 28.94% <ø> (+0.11%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Nov 05 '25 08:11 codecov-commenter

Should we drop support for Java8 in the next release? @zhoujinsong @baiyangtx @klion26

xxubai avatar Nov 11 '25 05:11 xxubai

is there an ETA for next release?

turboFei avatar Nov 11 '25 06:11 turboFei

I am okay to drop JDK8 in the next version, if it keeps us from uprading the iceberg version.

zhoujinsong avatar Nov 11 '25 06:11 zhoujinsong

As we have not deprecated JDK8 in 0.8.x, maybe we need to deprecate the jdk8 in 0.9.x and remove it in the version after 0.9.x(0.10.x or 1.0.x ). If we want to remove the JDK8 support more quickly, maybe we can make an earlier release for this.

klion26 avatar Nov 12 '25 15:11 klion26

maybe we can make an earlier release for this.

+1. In my view, the legacy burden of JDK 8 has become a hindrance to the advancement of the community.

turboFei avatar Nov 12 '25 18:11 turboFei

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Dec 13 '25 00:12 github-actions[bot]

As we have not deprecated JDK8 in 0.8.x, maybe we need to deprecate the jdk8 in 0.9.x and remove it in the version after 0.9.x(0.10.x or 1.0.x ). If we want to remove the JDK8 support more quickly, maybe we can make an earlier release for this.

The removal of support for JDK8 has been approved through voting on the mailing list. I am in favor of this decision. Moving forward, with support for V3 or higher versions, we can no longer maintain compatibility with JDK8. It's time to bid farewell to it.

czy006 avatar Dec 13 '25 06:12 czy006