amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-3470][Feature]:Enable catalog-level default properties storing into underlying tables within a unified catalog

Open nicochen opened this issue 8 months ago • 2 comments

Why are the changes needed?

Close #3470 .

Brief change log

  • Modify ‘create table’ function within flink/spark‘s unified catalog. Merges catalog-level properties which should be written into table metadata before creating table.

How was this patch tested?

  • [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

nicochen avatar Apr 28 '25 09:04 nicochen

Codecov Report

Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.40%. Comparing base (e69710a) to head (d8d739e). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...org/apache/amoro/utils/MixedFormatCatalogUtil.java 90.76% 2 Missing and 4 partials :warning:
...rg/apache/amoro/spark/SparkUnifiedCatalogBase.java 0.00% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3535      +/-   ##
============================================
+ Coverage     21.76%   28.40%   +6.63%     
- Complexity     2391     3730    +1339     
============================================
  Files           436      617     +181     
  Lines         40498    49860    +9362     
  Branches       5743     6442     +699     
============================================
+ Hits           8816    14162    +5346     
- Misses        30935    34681    +3746     
- Partials        747     1017     +270     
Flag Coverage Δ
core 28.40% <85.91%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Apr 28 '25 10:04 codecov-commenter

@zhoujinsong re-pull requested, PTAL

nicochen avatar Apr 29 '25 01:04 nicochen

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jul 17 '25 00:07 github-actions[bot]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Jul 24 '25 00:07 github-actions[bot]