[Bug]: The commit.retry.num-retries configuration does not take effect when configured on the catalog.

[lintingbin]

What happened?

In our production environment, we often encounter commit failure errors in Amoro. I tried to change the commit.retry.num-retries configuration on the catalog in Amoro to 30, but found that it didn't take effect. After troubleshooting, I discovered that during Amoro commit, the commitSimpleTransaction function in the org.apache.iceberg.BaseTransaction class is executed. This function retrieves the commit.retry.num-retries parameter directly from the metadata file's content, so the configuration set on the catalog does not take effect.

Affects Versions

0.7.1

What table formats are you seeing the problem on?

Iceberg

What engines are you seeing the problem on?

AMS

How to reproduce

No response

Relevant log output

No response

Anything else

No response

Are you willing to submit a PR?

• [X] Yes I am willing to submit a PR!

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

[zhoujinsong]

Although the catalog properties will not affect the engines like Flink/Spark for now However I do think it should affect the AMS, we may fix it.

[github-actions[bot]]

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

[github-actions[bot]]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'