amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Improvement] Redirect to login page if user doesn't login

Open chouchouji opened this issue 1 year ago • 3 comments

Why are the changes needed?

Close #xxx.

Brief change log

https://github.com/user-attachments/assets/9e824467-de8b-41ff-8b4d-e225a2244054

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

chouchouji avatar Oct 17 '24 13:10 chouchouji

Thanks for the work!

When I tested it in my local environment, I got some unexpected errors: When I try to open http://127.0.0.1:1630/overview page without logging, it can redirect to the login page, but after I fill in the username and password and click sign in, it cannot redirect to the overview page.

zhoujinsong avatar Oct 18 '24 02:10 zhoujinsong

logging

It may be a bug, I will fix it in recent days.

chouchouji avatar Oct 18 '24 03:10 chouchouji

Thanks for this contribution.

It really helps much. I used to meet this issue img_v3_02fj_47eaa5b9-fd87-4e32-a86e-e025eea48d6g

When backend restarted, refresh would encounter this plenty of errors. Will they disappear after this PR merged? @chouchouji

majin1102 avatar Oct 21 '24 12:10 majin1102

+1

czy006 avatar Oct 30 '24 02:10 czy006

Does this have anything to do with it #3340 cc @huyuanfeng2018

czy006 avatar Nov 26 '24 10:11 czy006

Does this have anything to do with it #3340 cc @huyuanfeng2018

I'm not sure, I wasn't focused here

huyuanfeng2018 avatar Nov 27 '24 02:11 huyuanfeng2018

Does this have anything to do with it #3340 cc @huyuanfeng2018

This PR does not conflict with the current PR. The two PRs focus on different points respectively and solve different problems. @czy006

baiyangtx avatar Nov 28 '24 03:11 baiyangtx