amoro icon indicating copy to clipboard operation
amoro copied to clipboard
verified publisher icon apache

[Improvement]: Display comment below the table name on the tables page

Open zhongqishang opened this issue 1 year ago • 9 comments

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

image

How should we improve?

Iceberg : get comment from table properties Mixed : ? Hudi : ? Paimon : ?

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

zhongqishang avatar Oct 12 '24 10:10 zhongqishang

If the task is not assigned, I want to improv it

monrg avatar Nov 25 '24 07:11 monrg

If the task is not assigned, I want to improv it

Sure, feel free to contribute. If you have any questions during the process, ping me.

zhoujinsong avatar Nov 25 '24 11:11 zhoujinsong

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar May 25 '25 00:05 github-actions[bot]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

github-actions[bot] avatar Jun 08 '25 00:06 github-actions[bot]

@monrg If you haven't had time to fix it lately, I'm going to fix this one

zhangwl9 avatar Jun 09 '25 07:06 zhangwl9

@zhoujinsong @zhongqishang I didn't find information about Comment tag in amoro_web/src/views/tables/index.vue and table page, is this pr a feature to be added

Image

zhangwl9 avatar Jun 09 '25 08:06 zhangwl9

@zhoujinsong @zhongqishang I didn't find information about Comment tag in amoro_web/src/views/tables/index.vue and table page, is this pr a feature to be added

@zhangwl9 Yes, this needs to be added, feel free to open PR.

zhongqishang avatar Jun 10 '25 13:06 zhongqishang

@zhoujinsong @zhongqishang I didn't find information about Comment tag in amoro_web/src/views/tables/index.vue and table page, is this pr a feature to be added

@zhangwl9 Yes, this needs to be added, feel free to open PR.

@zhoujinsong What information about the table is represented by the comment tag?

zhangwl9 avatar Jun 11 '25 09:06 zhangwl9

What information about the table is represented by the comment tag?

The table comment (description):

Refer : https://iceberg.apache.org/docs/nightly/spark-ddl/#alter-table-set-tblproperties https://paimon.apache.org/docs/1.1/spark/sql-alter/#changingadding-table-properties

zhongqishang avatar Jun 11 '25 11:06 zhongqishang