[AMORO-3143] Supports executing the spotless apply command on a single module
Why are the changes needed?
Close #3143.
Brief change log
- Modify the configuration file address of the spotless plug-in
How was this patch tested?
-
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
-
[ ] Add screenshots for manual tests if appropriate
-
[x] Run test locally before making a pull request
Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
@engraving-knife Thanks for your contribution.
IMO, maybe use maven.multiModuleProjectDirectory will be better, like
<file>${maven.multiModuleProjectDirectory}/tools/maven/scalafmt.conf</file>
FYI, In Maven 4.0, more options are provided. https://issues.apache.org/jira/browse/MNG-7038
@zhongqishang Thanks for your suggestion. I tried the multiModuleProjectDirectory attribute but it doesn't seem to work.
In addition, the official provides new properties to get the root directory of multi-module projects, but I think we should not use the properties of unreleased maven versions.
@zhongqishang Thanks for your suggestion. I tried the
multiModuleProjectDirectoryattribute but it doesn't seem to work.
Sorry for the missing information, also need to configure the maven.multiModuleProjectDirectory in VM options.
Reference in kyuubi : https://github.com/apache/kyuubi/blob/master/pom.xml#L1670
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.