amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Improvement]: Use Duration unit with Self-optimizing Configurations

Open czy006 opened this issue 1 year ago • 4 comments

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

Users need to manually calculate thousands of time / memory units every time. If it can be similar to the Apache Flink configuration, users can complete the configuration by specifying values ​​with memory units/time units, which will greatly facilitate the user experience.

for self-optimizing.minor.trigger.interval as an example

Before

  • self-optimizing.minor.trigger.interval
  • 3600000(1 hour)
  • The time interval in milliseconds to trigger minor optimizing

After

  • self-optimizing.minor.trigger.duration
  • 1hour/1day [0-9]+ (d | day | h | hour | m | min | minute | s | sec | second | ms | milli | millisecond | us | micro | microsecond | ns | nano | nanosecond)
  • Duration The time interval Duration to trigger minor optimizing

The before configuration will be removed in 0.9. We can recommend users to modify the configuration as soon as possible, and it should be noted in the upgrade log.

How should we improve?

  • add duration config support
  • add unit test with new duration config
  • Ensure compatibility of old configurations, and new configurations have higher priority

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

czy006 avatar Aug 20 '24 08:08 czy006

cc @zhoujinsong

czy006 avatar Aug 20 '24 08:08 czy006

This is a good idea to make our configuration more user-friendly.

However, we still need to discuss how to maintain compatibility with the old configuration values:

  1. Ignore the format error and use the default value
  2. Make the default unit to milliseconds and be compatibility with old values.

Besides, is this improvement affect both table properties and AMS configurations?

zhoujinsong avatar Aug 20 '24 08:08 zhoujinsong

This is a good idea to make our configuration more user-friendly.

However, we still need to discuss how to maintain compatibility with the old configuration values:

  1. Ignore the format error and use the default value
  2. Make the default unit to milliseconds and be compatibility with old values.

Besides, is this improvement affect both table properties and AMS configurations?

thanks for your feedback. I think this configuration will affect the table properties and AMS configuration.

If Amoro users upgrade to a higher version and do not modify the table configuration, it may not be read correctly.

Despite our best efforts to ensure compatibility, the old configuration will be removed from support after the next 2 versions (or 1.0 with amoro). We can recommend users to modify the configuration as soon as possible, and this should be noted in the upgrade log.

czy006 avatar Aug 20 '24 08:08 czy006

Flink memory configuration has been improved by #3409

klion26 avatar Jan 22 '25 01:01 klion26

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar Sep 09 '25 00:09 github-actions[bot]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

github-actions[bot] avatar Sep 24 '25 00:09 github-actions[bot]