amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-2988] Add more base info for the table detail page

Open tcodehuber opened this issue 1 year ago • 11 comments

Why are the changes needed?

Close #2988.

Brief change log

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

tcodehuber avatar Jul 01 '24 11:07 tcodehuber

It is OK to display other dimensions of information under the title, but I have a small suggestion. The information under the current table title and the metrics column on the right are a lot of duplication. I think the information under the title can be simplified. For example, the last commit time, table size, file count, avg file size and other information can be placed on the right.

xxubai avatar Jul 01 '24 13:07 xxubai

It is OK to display other dimensions of information under the title, but I have a small suggestion. The information under the current table title and the metrics column on the right are a lot of duplication. I think the information under the title can be simplified. For example, the last commit time, table size, file count, avg file size and other information can be placed on the right.

If the optimizing status, records and table format is remained under the current table title, is it OK or do you have any suggestion which else information can be displayed there?

tcodehuber avatar Jul 02 '24 01:07 tcodehuber

It is OK to display other dimensions of information under the title, but I have a small suggestion. The information under the current table title and the metrics column on the right are a lot of duplication. I think the information under the title can be simplified. For example, the last commit time, table size, file count, avg file size and other information can be placed on the right.

@XBaith If the optimizing status, records and table format is remained under the current table title, is it OK or do you have any suggestion which else information can be displayed there?

tcodehuber avatar Jul 02 '24 01:07 tcodehuber

@XBaith If the optimizing status, records and table format is remained under the current table title, is it OK or do you have any suggestion which else information can be displayed there?

That's ok for me. We can display full table identifier as title, <catalog>.<database>.<table> image

xxubai avatar Jul 02 '24 02:07 xxubai

I think some of the metrics under the table identifier that duplicate the right hand side detail metrics should be removed, WDYT?

xxubai avatar Jul 02 '24 08:07 xxubai

I think some of the metrics under the table identifier that duplicate the right hand side detail metrics should be removed, WDYT?

frontend or backend code? Can you show me more details, thanks.

tcodehuber avatar Jul 02 '24 09:07 tcodehuber

last commit time, table size, file count, avg file size

Front side, metrics: last commit time, table size, file count and avg file size can be removed from the title?

xxubai avatar Jul 02 '24 10:07 xxubai

image

tcodehuber avatar Jul 02 '24 10:07 tcodehuber

last commit time, table size, file count, avg file size

Front side, metrics: last commit time, table size, file count and avg file size can be removed from the title?

Updated.

tcodehuber avatar Jul 02 '24 10:07 tcodehuber

@tcodehuber Thanks for the contribution!

I'm wondering if Optimizing Status would be better. Optimizing highlights our continuous optimization capability, and here the status perfectly corresponds to the ongoing actions of continuous optimization.

zhoujinsong avatar Jul 04 '24 06:07 zhoujinsong

@tcodehuber Thanks for the contribution!

I'm wondering if Optimizing Status would be better. Optimizing highlights our continuous optimization capability, and here the status perfectly corresponds to the ongoing actions of continuous optimization.

OK, I have followed your suggestion.

tcodehuber avatar Jul 04 '24 08:07 tcodehuber