amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Improvement]: Integrate the log records of debug, info, and error into one file

Open xleoken opened this issue 1 year ago • 3 comments

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

It is not a good practice to record the log records of debug, info, and error separately in different files, and there is a contextual linking relationship between them.

[dcadmin@dcadmin-work logs]$  ll
total 179988
-rw-rw-r-- 1 dcadmin dcadmin         0 Jun 21 16:31 amoro-metrics.log
-rw-rw-r-- 1 dcadmin dcadmin         0 Jun 21 16:31 ams-debug.log
-rw-rw-r-- 1 dcadmin dcadmin  35377462 Jun 21 17:51 ams-error.log
-rw-rw-r-- 1 dcadmin dcadmin 148887752 Jun 21 17:51 ams-info.log
-rw-rw-r-- 1 dcadmin dcadmin         0 Jun 21 16:31 app.log.err
-rw-rw-r-- 1 dcadmin dcadmin     25485 Jun 21 17:51 gc.log.0.current

How should we improve?

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

xleoken avatar Jun 21 '24 10:06 xleoken

i can take this :)

daragu avatar Jun 25 '24 09:06 daragu

As far as I know, the ams-info.log file now also includes warning and error logs. Similarly, the ams-debug.log file contains all logs(disable by default).

zhoujinsong avatar Jun 25 '24 10:06 zhoujinsong

@daragu thanks for taking this, but we are still discussing this issue.

xleoken avatar Jun 26 '24 06:06 xleoken