amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-2811][Bug][FLINK]: flink unified catalog doesn't support mixed_hive

Open Aireed opened this issue 1 year ago • 2 comments

Why are the changes needed?

Close #2811 .

Brief change log

create table if not exists xxxx (
....
);

A unifiedCatalog which metastore is hms.

  • when create a mixed-hive table:

    • If there is a table in mixed-hive format with the same name, the program can execute correctly with no error thrown and the table is not overwrited;
    • If there is a table in hive format with the same name, the program will throw an error,
    • If there is no table with the same name, a mixed-hive table will be created.
  • when create a iceberg table

    • if there is a table in iceberg format with the same name, the program can execute correctly with no error ,and the table is not overwrited;
    • If there is no table with the same name, a iceberg table will be created.
  • when create a mixed-iceberg table

    • If there is a table in iceberg format with the same name, the program can execute correctly with no error thrown and the table is not overwrited;
    • If there is a table in hive format with the same name, the program should thrown an error to indicate the table does exist;
    • If there is no table with the same name, an iceberg table will be created.

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Aireed avatar May 07 '24 06:05 Aireed

cc @YesOrNo828 @xieyi888 PTAL.

Aireed avatar May 07 '24 06:05 Aireed

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 27.47%. Comparing base (a2753b6) to head (c17965a). Report is 8 commits behind head on master.

Files Patch % Lines
...rg/apache/amoro/hive/catalog/MixedHiveCatalog.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2814      +/-   ##
============================================
- Coverage     35.95%   27.47%   -8.48%     
- Complexity      383     2483    +2100     
============================================
  Files            45      360     +315     
  Lines          4700    37210   +32510     
  Branches        513     5434    +4921     
============================================
+ Hits           1690    10225    +8535     
- Misses         2842    26026   +23184     
- Partials        168      959     +791     
Flag Coverage Δ
trino 27.47% <0.00%> (-8.48%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 24 '24 09:05 codecov-commenter