amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Improvement]: align term 'transaction' with Iceberg 'snapshot'

Open link3280 opened this issue 1 year ago • 2 comments

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, snapshots are called transactions both in the codebase and the web UI, but under the hood they're the same for Iceberg users (perhaps some functionalities improvement for mixed formats).

I proposed to rename transactions to snapshots, which is more understandable for new users.

How should we improve?

No response

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

link3280 avatar Apr 16 '24 06:04 link3280

There's context for this.

Amoro name transacions on snapshots which are not produced by amoro optimizing.... You could see transactions and optimized two tabs. Both of them consists all snapshots.

We could discuss furthur if this is necessary

majin1102 avatar Apr 27 '24 14:04 majin1102

There's context for this.

Amoro name transacions on snapshots which are not produced by amoro optimizing.... You could see transactions and optimized two tabs. Both of them consists all snapshots.

We could discuss furthur if this is necessary

@majin1102 Thanks for your input. I suppose you mean add-on transaction capabilities (e.g. transaction blockers) provided by mixed formats? But if I understand correctly there's no fundamental difference.

link3280 avatar May 03 '24 10:05 link3280

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar Oct 31 '24 00:10 github-actions[bot]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

github-actions[bot] avatar Nov 14 '24 00:11 github-actions[bot]