amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[WIP][AMORO-2623] Add CAS-based state mechanism to TaskRuntime

Open link3280 opened this issue 1 year ago • 2 comments

Why are the changes needed?

Close #2623.

Brief change log

  • Add CAS check based on optimizer thread to TaskRuntime.

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

link3280 avatar Mar 22 '24 10:03 link3280

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.01%. Comparing base (40707a5) to head (76aa9d0). Report is 6 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2664       +/-   ##
=============================================
+ Coverage     34.82%   51.01%   +16.19%     
+ Complexity     4506      592     -3914     
=============================================
  Files           605       46      -559     
  Lines         50623     4708    -45915     
  Branches       6655      513     -6142     
=============================================
- Hits          17631     2402    -15229     
+ Misses        31540     2079    -29461     
+ Partials       1452      227     -1225     
Flag Coverage Δ
core ?
trino 51.01% <ø> (+0.14%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 22 '24 10:03 codecov[bot]

Thanks for your contribution, I left some comments, PTAL

majin1102 avatar Mar 23 '24 06:03 majin1102

Close in favor of #2684

link3280 avatar Mar 28 '24 02:03 link3280