amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-2662]After the token expires,the optimizer repeatedly commits tasks that have been reset to ams

Open rfyu opened this issue 1 year ago • 1 comments

Why are the changes needed?

Close #2662

Brief change log

  • Added an IllegalTaskException

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

rfyu avatar Mar 22 '24 07:03 rfyu

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 34.72%. Comparing base (79e0ce6) to head (e278de1). Report is 5 commits behind head on master.

Files Patch % Lines
.../netease/arctic/server/optimizing/TaskRuntime.java 0.00% 3 Missing :warning:
.../arctic/server/exception/TaskRuntimeException.java 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2663      +/-   ##
============================================
- Coverage     34.80%   34.72%   -0.08%     
- Complexity     4512     4519       +7     
============================================
  Files           606      608       +2     
  Lines         50668    50959     +291     
  Branches       6661     6683      +22     
============================================
+ Hits          17634    17697      +63     
- Misses        31590    31808     +218     
- Partials       1444     1454      +10     
Flag Coverage Δ
core 33.07% <28.57%> (-0.14%) :arrow_down:
trino 50.93% <ø> (+0.57%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 22 '24 07:03 codecov[bot]