[AMORO-2656] Enhance TimeUtils and fix config parsing error
Why are the changes needed?
Close #2656.
Brief change log
- Support month/year time unit
- Stability enhancement
How was this patch tested?
-
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
-
[ ] Add screenshots for manual tests if appropriate
-
[x] Run test locally before making a pull request
Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not documented)
Codecov Report
Attention: Patch coverage is 46.82540% with 67 lines in your changes are missing coverage. Please review.
Project coverage is 34.12%. Comparing base (
82691aa) to head (43044f6).
Additional details and impacted files
@@ Coverage Diff @@
## master #2657 +/- ##
============================================
+ Coverage 33.96% 34.12% +0.15%
- Complexity 4357 4377 +20
============================================
Files 604 605 +1
Lines 50754 50774 +20
Branches 6673 6668 -5
============================================
+ Hits 17241 17328 +87
+ Misses 32124 32043 -81
- Partials 1389 1403 +14
| Flag | Coverage Δ | |
|---|---|---|
| core | 32.41% <46.82%> (+0.11%) |
:arrow_up: |
| trino | 50.93% <ø> (+0.57%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We may need to remove one of the duplicated classes in ams-api and ams-server like com.netease.arctic.server.table.DataExpirationConfig. Keeping them for a long time may bring too much additional work.
@majin1102 @XBaith
We may need to remove one of the duplicated classes in
ams-apiandams-serverlikecom.netease.arctic.server.table.DataExpirationConfig
+1 👍
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.