amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-2612]Avoid task always being in scheduled state

Open rfyu opened this issue 1 year ago • 2 comments

Why are the changes needed?

Close #2612.

Brief change log

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

rfyu avatar Mar 09 '24 04:03 rfyu

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 34.81%. Comparing base (0867c7c) to head (c607418).

Files Patch % Lines
...etease/arctic/server/DefaultOptimizingService.java 80.00% 0 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2613      +/-   ##
============================================
+ Coverage     34.79%   34.81%   +0.01%     
- Complexity     4519     4521       +2     
============================================
  Files           607      607              
  Lines         50757    50762       +5     
  Branches       6671     6671              
============================================
+ Hits          17662    17671       +9     
+ Misses        31641    31636       -5     
- Partials       1454     1455       +1     
Flag Coverage Δ
core 33.15% <84.61%> (+<0.01%) :arrow_up:
trino 50.99% <ø> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 09 '24 04:03 codecov[bot]

@majin1102 @XBaith @zhoujinsong Thanks a lot for your guidance. I agree with your proposal. Please review it again.

rfyu avatar Mar 22 '24 07:03 rfyu