amoro icon indicating copy to clipboard operation
amoro copied to clipboard
verified publisher icon apache

[AMORO-2496][DOC]: Add configuration docs for AMS terminal

Open czy006 opened this issue 1 year ago • 3 comments

Why are the changes needed?

Close #2496.

Brief change log

  • Add configuration docs for AMS terminal

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

czy006 avatar Mar 07 '24 12:03 czy006

Hi, I left some comments, PTAL

majin1102 avatar Mar 07 '24 12:03 majin1102

@czy006 Hi, thanks a lot for your contribution!

Now all configurations of AMS are described in docs/admin-guides/deployment.md#Configuration. I think you should move these new descriptions into it.

And docs/user-guides/configuration.md is used to describe the configurations of tables now.

zhoujinsong avatar Mar 08 '24 02:03 zhoujinsong

@czy006 Hi, thanks a lot for your contribution!

Now all configurations of AMS are described in docs/admin-guides/deployment.md#Configuration. I think you should move these new descriptions into it.

And docs/user-guides/configuration.md is used to describe the configurations of tables now.

The new commit has been moved to the correct location

czy006 avatar Mar 09 '24 11:03 czy006

I left some comments, PTAL

Thanks for your contribution and correction. By the way, I extracted these parameter descriptions from ArcticManagementConf. Does this mean that these descriptions need to be modified as well?

czy006 avatar Mar 27 '24 01:03 czy006

I left some comments, PTAL

Thanks for your contribution and correction. By the way, I extracted these parameter descriptions from ArcticManagementConf. Does this mean that these descriptions need to be modified as well?

Yes, I think these descriptions shoud be modified as well.

baiyangtx avatar Mar 27 '24 09:03 baiyangtx