[AMORO-2540] Report expiring snapshots event for Iceberg and mixed format
Why are the changes needed?
Close #2540 .
Brief change log
- Report expire snapshots event to downstream listeners
How was this patch tested?
-
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
-
[ ] Add screenshots for manual tests if appropriate
-
[x] Run test locally before making a pull request
Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
Codecov Report
Attention: Patch coverage is 74.33628% with 58 lines in your changes are missing coverage. Please review.
Project coverage is 32.61%. Comparing base (
2808413) to head (f15c295).
Additional details and impacted files
@@ Coverage Diff @@
## master #2541 +/- ##
============================================
+ Coverage 32.44% 32.61% +0.16%
- Complexity 4412 4433 +21
============================================
Files 590 596 +6
Lines 50055 50260 +205
Branches 6622 6640 +18
============================================
+ Hits 16242 16391 +149
- Misses 32533 32578 +45
- Partials 1280 1291 +11
| Flag | Coverage Δ | |
|---|---|---|
| core | 30.71% <74.33%> (+0.18%) |
:arrow_up: |
| trino | 50.93% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi, thanks for this wonderful feature.
I wonder if you can somehow explain the motivation of this definition?
I wonder if you can somehow explain the motivation of this definition?
The purpose is to report information about files that have been deleted after the expiration timestamp, such as the path to the file, so that downstream systems can monitor or utilize this information for appropriate operations. But after discussing with @zhoujinsong , I think the reported information should be as concise as possible, and also need to wait for the API to be refactored to handle it.
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.