amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-2215] Optimize the speed of searching for tables in the tables navigation bar

Open tcodehuber opened this issue 2 years ago • 4 comments

Why are the changes needed?

Close #2215.

Brief change log

  • If all the databases have been loaded, searching db action will not trigger querying backend;
  • If all the tables have been loaded, searching tb action will not trigger querying backend Similarly.

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

tcodehuber avatar Dec 19 '23 09:12 tcodehuber

@zhoujinsong @hameizi Can you take some time to review the PR? I have tested in my own env, in which it works ok.

tcodehuber avatar Dec 19 '23 09:12 tcodehuber

Sorry for the late reply. @tcodehuber

We have recently done some refactoring on the front-end, so there are some conflicts that need to be resolved. Afterward, we can proceed with merging this PR.

BTW, there are some changes when building the front-end, you can refer to ams/dashboard/README.md.

wangtaohz avatar Dec 25 '23 07:12 wangtaohz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.71%. Comparing base (82691aa) to head (06b3fdf).

:exclamation: Current head 06b3fdf differs from pull request most recent head ec5d4a3. Consider uploading reports for the commit ec5d4a3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2452      +/-   ##
============================================
+ Coverage     33.96%   34.71%   +0.74%     
- Complexity     4357     4521     +164     
============================================
  Files           604      608       +4     
  Lines         50754    50980     +226     
  Branches       6673     6686      +13     
============================================
+ Hits          17241    17698     +457     
+ Misses        32124    31829     -295     
- Partials       1389     1453      +64     
Flag Coverage Δ
core 33.06% <ø> (+0.77%) :arrow_up:
trino 50.89% <ø> (+0.53%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 26 '23 02:12 codecov[bot]

@wangtaohz I have resolved conflicts, please review it again.

tcodehuber avatar Dec 26 '23 02:12 tcodehuber