amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-2391] For Mixed-Hive tables, default refresh time for Hive partitions should be configured

Open shendanfengg opened this issue 2 years ago • 2 comments

Why are the changes needed?

Close #2391

Brief change log

-Set the default value of REFRESH_HIVE_INTERVAL to half an hour

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

shendanfengg avatar Nov 30 '23 09:11 shendanfengg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ca2061e) 52.96% compared to head (bd8f9e6) 50.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2392      +/-   ##
============================================
- Coverage     52.96%   50.95%   -2.01%     
+ Complexity     4303      590    -3713     
============================================
  Files           516       46     -470     
  Lines         29716     4708   -25008     
  Branches       2896      513    -2383     
============================================
- Hits          15739     2399   -13340     
+ Misses        12699     2084   -10615     
+ Partials       1278      225    -1053     
Flag Coverage Δ
core ?
trino 50.95% <ø> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 30 '23 10:11 codecov[bot]

@shendanfengg I saw you trying to change the default value of base.hive.refresh-interval in order to refresh the data in Hive for all Mixed-Hive format tables every half an hour by default.

This configuration was initially disabled because we couldn't ensure that all users of Mixed-Hive format tables have this requirement. Can you adjust the default configuration under Catalog to enable this feature for all your Mixed-Hive tables instead of directly changing the default value of this configuration? I still can't confirm that all users of Mixed-Hive format tables have this requirement.

zhoujinsong avatar Dec 05 '23 05:12 zhoujinsong

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Aug 22 '24 00:08 github-actions[bot]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Aug 29 '24 00:08 github-actions[bot]