[AMORO-2338] Incorrect display of props in hive upgrade page
Why are the changes needed?
Close #2338 .
Brief change log
-Modify the filter for props
How was this patch tested?
-
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
-
[ ] Add screenshots for manual tests if appropriate
-
[x] Run test locally before making a pull request
Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.
Comparison is base (
25cf7ae) 52.69% compared to head (e8ecc39) 52.69%.
| Files | Patch % | Lines |
|---|---|---|
| ...java/com/netease/arctic/table/TableProperties.java | 0.00% | 2 Missing :warning: |
| ...netease/arctic/server/dashboard/utils/AmsUtil.java | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #2339 +/- ##
=========================================
Coverage 52.69% 52.69%
+ Complexity 4219 4214 -5
=========================================
Files 511 510 -1
Lines 29333 29308 -25
Branches 2851 2851
=========================================
- Hits 15456 15443 -13
+ Misses 12632 12620 -12
Partials 1245 1245
| Flag | Coverage Δ | |
|---|---|---|
| core | 53.04% <0.00%> (+0.01%) |
:arrow_up: |
| trino | 50.87% <ø> (-0.09%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The title of the PR is supposed to be [AMORO-XXXX] @shendanfengg
The title of the PR is supposed to be
[AMORO-XXXX]@shendanfengg I've modified it.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: shendanfengg
:x: shendanfeng
shendanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@shendanfengg @wangtaohz I think we should continue to improve this PR and rebase it.I will try to continue
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.