amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-1794] Add cache catalog config for iceberg catalog

Open zhongqishang opened this issue 2 years ago • 5 comments

Why are the changes needed?

Fix #1794

Brief change log

  • Use CachingCatalog wrap caltalog
  • Add class IcebergCachingCatalogWrapper.java

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

zhongqishang avatar Aug 04 '23 03:08 zhongqishang

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 33.98%. Comparing base (34bb1a5) to head (a8a2fe3).

Files Patch % Lines
...netease/arctic/formats/iceberg/IcebergCatalog.java 64.28% 3 Missing and 2 partials :warning:
...va/com/netease/arctic/utils/ArcticCatalogUtil.java 58.33% 3 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1795      +/-   ##
============================================
- Coverage     34.03%   33.98%   -0.05%     
+ Complexity     4364     4361       -3     
============================================
  Files           604      604              
  Lines         50748    50753       +5     
  Branches       6671     6671              
============================================
- Hits          17271    17249      -22     
- Misses        32078    32117      +39     
+ Partials       1399     1387      -12     
Flag Coverage Δ
core 32.30% <62.96%> (+<0.01%) :arrow_up:
trino 50.38% <ø> (-0.58%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 24 '23 06:08 codecov[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 22 '23 08:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 22 '23 08:11 CLAassistant

Maybe this PR could be closed due to this PR https://github.com/NetEase/amoro/pull/2298

baiyangtx avatar Dec 01 '23 10:12 baiyangtx

Maybe this PR could be closed due to this PR #2298

@baiyangtx In #2298, It seems that cache support for the native iceberg format catalog is missing, I have added it in the this PR.

PTAL.

zhongqishang avatar Jan 03 '24 03:01 zhongqishang

@zhongqishang There is a conflict with master branch, could you fix that?

baiyangtx avatar Mar 23 '24 15:03 baiyangtx