amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Spark][Improvement]: Support conflict check for Mixed-Hive format UnkeyedTable

Open baiyangtx opened this issue 2 years ago • 3 comments

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

For mixed-format unkeyed table. there is no conflict check during committing, this may cause inconsistency of data.

How should we improve?

Add a conflict check when doing base store commit.

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

baiyangtx avatar Feb 01 '23 07:02 baiyangtx

Does this improvement only affect the mixed-hive format unkeyed table? Do the mixed-iceberg format table and mixed-streaming keyed table need this improvement too?

zhoujinsong avatar Feb 02 '23 02:02 zhoujinsong

Does this improvement only affect the mixed-hive format unkeyed table? Do the mixed-iceberg format table and mixed-streaming keyed table need this improvement too?

@zhoujinsong

currently, the mixed-streaming keyed table writes to change store, so there is no conflict that should be done. for the mixed-iceberg format, the unkeyed table uses native iceberg cow as implementation, so we don't need to care about conflict checking.

In the future, the mixed-streaming keyed table will write to the base store and the mixed-iceberg table will not use native iceberg row-level operation implement, in that time, the writing conflict checking needs to be implemented.

baiyangtx avatar Feb 02 '23 06:02 baiyangtx

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar Aug 20 '24 00:08 github-actions[bot]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

github-actions[bot] avatar Feb 11 '25 00:02 github-actions[bot]