AMBARI-26343 React Implementation: Authentication Components
Ambari-Web React Implementation: Authentication Components
What changes were proposed in this pull request?
fix AMBARI-26343
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests) (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.
before login
after login
Thanks @zRains cc
Hi @nikita15p , yes it is for ambari-web, and the login component is part of the ambari-web, but i dont see there is merites to create three seperate react front end projects, react router will take care of the rest.
@chenyuan99 My understanding is that these frontend projects are being developed in a merged manner, similar to a Monorepo?
yes you are right, since react is a component based frontend framework, it is a good idea keep the components in the same place to make the components reusable
Reference: Sharing history on the design plan of modernisation work https://github.com/apache/ambari/pull/3967#issuecomment-2750194442
Hi @nikita15p , yes it is for ambari-web, and the login component is part of the ambari-web, but i dont see there is merites to create three seperate react front end projects, react router will take care of the rest.
@chenyuan99, seems this is a design change and a diversion from existing implementation. Separation of modules exists since inception and re-birth of the project. Since this is a design change can you kindly share a document proposing and justifying the same. Request to kindly create a document and attach the same to the jira ticket proposing and justifying the unification of different modules. This would also require a design think and discussion within the ambari community and also would be good if you can send a mail proposing the same. The current branch was created with a proposal to re-write the existing implementation in the react framework only, can we take this up once the re-write of the existing modules is completed. Thanks.