ambari

ambari copied to clipboard

Reame
Issues

AMBARI-26059: Update builder and resource provider

Open tarihub opened this issue 1 year ago • 5 comments

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests) (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

Mar 02 '24 03:03 tarihub

@tarihub thanks for reporting and working on this. Could you please add one Unit Test case for this and attach the validation snapshots after fixing this.?

Apr 15 '24 03:04 brahmareddybattula

of course～

Apr 15 '24 06:04 tarihub

I've been a little busy lately, it might take a while

Apr 17 '24 11:04 tarihub

Hi @brahmareddybattula , I add Unit Test for this problem which would be fail if takes the origin unpatch code

After patch, Unit Test will run successfully.

Validation for this fix: script.filename can't be injectable.

May 06 '24 00:05 tarihub

@tarihub looks like CI has not run for this PR. Can you rebase and push again?

Sep 25 '24 21:09 sandeep318kumar

@tarihub looks like CI has not run for this PR. Can you rebase and push again?

@sandeep318kumar hello, I merge the latest commit, but CI still not run

update: CI may seems run, but I don't have jenkins permission to see detail

Oct 26 '24 14:10 tarihub