airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Fix Python debugger hang when python_callable has **context parameter

Open AmosG opened this issue 1 month ago • 4 comments

Add iter methods to Accessor classes to prevent debugger introspection from triggering infinite loops in getattr.

Issue: #51861


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

AmosG avatar Nov 29 '25 12:11 AmosG

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Nov 29 '25 12:11 boring-cyborg[bot]

You need to fix static checks

potiuk avatar Dec 06 '25 08:12 potiuk

cc: @uranusjr @ashb -> since you were closest to this. I dug a little deeper - and I was thinking that magic/dunder methods are not going through regular getatr calls, so to be honest, so it's pretty strange those recursive behavious are observed here- and I do not particularly like how "specia" the handling is. Maybe you have some more insight into that ?

potiuk avatar Dec 10 '25 17:12 potiuk

i think i found another place that causes this on utils/context.py on getattr would amend the pr

AmosG avatar Dec 10 '25 19:12 AmosG