apache
Fix/Invalid uri created when extras contains non string elements
This PR fixes how Connection.get_uri() handles extras with non-string values (floats, booleans, nested dicts).
Extras are now stringified before encoding to produce valid, SQLAlchemy-compatible URIs.
Added a unit test test_get_uri_with_non_string_extras to verify the change.
All pre-commit checks passed.
Issue :#55893
@Lee-W @jason810496 Could you please take a look at this PR when you have a moment?
Thanks for the review — I’m still working on it locally. I’ve made some progress and should be able to push the updated changes tomorrow.
Will this fix be released soon?
Depends when it will get green, approved, merged and relesed. In open-source "soon" might mean many things and generally the answer "when" is "when ready". People contribute to open source when they can - and sometimes it's faster, sometimes slower.
But if you would like to speed it up - doing reviews or even asking to take over the PR and get it merged (i.e. green and passing review) quickly is a better way that asking "when". Highly recommended.
Will this fix be released soon?
Depends when it will get green, approved, merged and relesed. In open-source "soon" might mean many things and generally the answer "when" is "when ready". People contribute to open source when they can - and sometimes it's faster, sometimes slower.
But if you would like to speed it up - doing reviews or even asking to take over the PR and get it merged (i.e. green and passing review) quickly is a better way that asking "when". Highly recommended.
I agree with you. I found info on chat that some changes are created internally and I am only asked for timeline - not to speed up.