apache
Add notification on successful canary run
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
I worry if it will add too much noise on the channel and hard to filter the runs to watch out for the CI team. Trying to understand what your thought were behind this?
To get some "positivity" (and heartbeat) in the channel.
Positivity - too long of "negative" messages in the channel might have long time "burn-out" effect (i.e.. things failed again!). Also to see that we do have periods of "successes"..
Heartbeat - I am personally - when do not see a notification, sometimes worried if things worked or if there is something wrong with notification :).
However yes - I agree it might be too much noise, so maybe we can fine-tune it. For example we could attempt to only notify once a day or, maybe the first time it happens (though then we loose the "heartbeat". Or maybe have much simpler message (just "succeeded" might be enough).
Maybe others can have other ideas :) ?
Maybe others can have other ideas :) ?
can we easily duplicate the system tests dashboards that some some providers has for the CI runs?
can we easily duplicate the system tests dashboards that some some providers has for the CI runs?
No.
a) we do not have credentials, b) they are managed and run internally by each of the team that runs system tests in their way.
I am happy if no failure message pops-up. That is also my signal to check the channel for problems. If positive messages are also dropped there then I see always "unread" stuff. Personally tooo much noise.
Could we make it that for people who are interested personal success messages are dropped? Badge in Readme also is a good indicator.
Hm.. Maybe updating description with "3 days since last failure" would do the job (following our favourite meme):
But I think that also triggers channel "unread" ? Did you see that I changed description for tests?
Hm.. Maybe updating description with "3 days since last failure" would do the job (following our favourite meme):
I saw this but channel kept being "read" - But I am only 80% sure. But this might be a good option marking this via channel header.
Positivity - too long of "negative" messages in the channel might have long time "burn-out" effect (i.e.. things failed again!). Also to see that we do have periods of "successes"..
True. Maybe we need to fine tune it so that we report maybe a daily report or so, 1 message better to makr read than n of them!
A different channel could be beneficial, allowing only those who want to read it. We still need to check the CI channel as well
