airflow icon indicating copy to clipboard operation
airflow copied to clipboard

AIP-86 - Calculate and store the dagrun Deadline

Open ferruzzi opened this issue 5 months ago • 1 comments

When starting a new dagrun or marking a dagrun as QUEUED, if the DAG has a deadline and that deadline is calculated off one of these dagrun values, then calculate that timestamp and add it to the db table.


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

ferruzzi avatar Jun 12 '25 00:06 ferruzzi

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Jun 12 '25 00:06 boring-cyborg[bot]

@ashb @uranusjr @pierrejeambrun I've addressed all the unresolved comments so I'm looking for a re-review

ramitkataria avatar Jun 26 '25 22:06 ramitkataria

@o-nikolas pointed out an opportunity to make it a little more efficient, so I took that. Final revision (I hope)

ferruzzi avatar Jul 08 '25 02:07 ferruzzi