airflow icon indicating copy to clipboard operation
airflow copied to clipboard

AIP-81 Transition of Version Command

Open Prab-27 opened this issue 7 months ago • 12 comments

closes : #45670

Implement Version Command on the CLI side


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Prab-27 avatar May 21 '25 17:05 Prab-27

Adding ActionCommand requires a deep dive since it is not working as expected. I'm working on fixing it

Prab-27 avatar May 22 '25 17:05 Prab-27

cc: @bugraoz93

If that's okay, I'll add the tests tomorrow.

Prab-27 avatar May 27 '25 16:05 Prab-27

I need to update some code. I will make the changes tomorrow morning as soon as possible

Prab-27 avatar May 28 '25 17:05 Prab-27

Using Version_operation and api_client.version.get() both cases it will show this logging :

[2025-05-29T11:14:08.670+0000] {_client.py:1026} INFO - HTTP Request: GET http://localhost:8080/api/v2/version "HTTP/1.1 200 OK" then version_dict

Could you please help me prevent this message from appearing

Prab-27 avatar May 29 '25 12:05 Prab-27

cc : @bugraoz93

Prab-27 avatar Jun 03 '25 13:06 Prab-27

Using Version_operation and api_client.version.get() both cases it will show this logging :

[2025-05-29T11:14:08.670+0000] {_client.py:1026} INFO - HTTP Request: GET http://localhost:8080/api/v2/version "HTTP/1.1 200 OK" then version_dict

Could you please help me prevent this message from appearing

Thanks for tagging @Prab-27! I missed this. I will look, but we can handle this disabled log in a separate PR. Let's first finish the version command and merge it. I think that part should be disabled in the client that will apply to all commands. Great catch!

bugraoz93 avatar Jun 03 '25 16:06 bugraoz93

Using Version_operation and api_client.version.get() both cases it will show this logging : [2025-05-29T11:14:08.670+0000] {_client.py:1026} INFO - HTTP Request: GET http://localhost:8080/api/v2/version "HTTP/1.1 200 OK" then version_dict Could you please help me prevent this message from appearing

Thanks for tagging @Prab-27! I missed this. I will look, but we can handle this disabled log in a separate PR. Let's first finish the version command and merge it. I think that part should be disabled in the client that will apply to all commands. Great catch!

Thanks !! I'll start working on this in a couple of days

Prab-27 avatar Jun 04 '25 12:06 Prab-27

@bugraoz93 The static checks are not automatically fixed. Could you please tell me how to resolve these checks?

Prab-27 avatar Jun 05 '25 13:06 Prab-27

Can I copy - paste from the main branch to fix this check? I don't have enough knowledge about these files

Prab-27 avatar Jun 05 '25 13:06 Prab-27

@bugraoz93 The static checks are not automatically fixed. Could you please tell me how to resolve these checks?

Fixed

Prab-27 avatar Jun 06 '25 17:06 Prab-27

@bugraoz93 The static checks are not automatically fixed. Could you please tell me how to resolve these checks?

Fixed

It was quite busy days for me so I couldn't give some pointers. It's great to see it is fixed! Thanks a lot, @Prab-27! I will check this in detail soon

bugraoz93 avatar Jun 06 '25 18:06 bugraoz93

Hey @Prab-27, can you please rebase the branch? We can directly merge it afterwards. I can also do it if you don't have time

bugraoz93 avatar Jun 17 '25 21:06 bugraoz93