airflow icon indicating copy to clipboard operation
airflow copied to clipboard

WIP - Bugfix/edge worker pid file

Open OliverWannenwetsch opened this issue 1 year ago • 1 comments

Summary

This is a PR draft, which not finished yet

OliverWannenwetsch avatar Oct 18 '24 11:10 OliverWannenwetsch

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Oct 18 '24 11:10 boring-cyborg[bot]

+1: I see a couple of static checks failing, please run either pre-commit over your changes or breeze static-checks

Note: I'd ignore most of the other errors in the pipeline, seems to be CI general in-stabiltiy)

jscheffl avatar Oct 21 '24 14:10 jscheffl

+1... as we are on main but not releasing the package atm because it is not ready, can you please:

  • increment the third digit of the version number in providers/src/airflow/providers/edge/provider.yaml
  • Add some notes in changelog in providers/src/airflow/providers/edge/CHANGELOG.rst ?

THANKS!

jscheffl avatar Oct 21 '24 14:10 jscheffl

+1: I see a couple of static checks failing, please run either pre-commit over your changes or breeze static-checks

Note: I'd ignore most of the other errors in the pipeline, seems to be CI general in-stabiltiy)

Fixed in commit 1d0cb9c0b8

OliverWannenwetsch avatar Oct 22 '24 11:10 OliverWannenwetsch

+1... as we are on main but not releasing the package atm because it is not ready, can you please:

  • increment the third digit of the version number in providers/src/airflow/providers/edge/provider.yaml
  • Add some notes in changelog in providers/src/airflow/providers/edge/CHANGELOG.rst ?

THANKS!

Fixed in commit 33fb87513e84f

OliverWannenwetsch avatar Oct 22 '24 11:10 OliverWannenwetsch

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar Oct 22 '24 11:10 boring-cyborg[bot]