airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Upgrade databricks provider dependency databricks-sql-connector to support version >= 3.0

Open rubanolha opened this issue 1 year ago • 3 comments

Updated the dependency constraint for databricks-sql-connector for databricks provider. It updates the databricks-sql-connector dependency to support version >= 3.0 which is released on Nov 17, 2023. Upgrading to version >= 3.0 is crucial for compatibility with other packages, especially dbt, and resolves a blocker impacting many users' workflows. closes: https://github.com/apache/airflow/issues/39274


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

rubanolha avatar Oct 01 '24 17:10 rubanolha

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Oct 01 '24 17:10 boring-cyborg[bot]

As sqlalchemy is optional for databricks-sql-connector starting from v3.0.0, the expectation that it will not be blocked by deprecations of SQLAlchemy 2.

rubanolha avatar Oct 01 '24 18:10 rubanolha

Checks are failing

potiuk avatar Oct 13 '24 01:10 potiuk

You need to rebase, and fix static checks that are resulting from switching to the new databricks provider.

potiuk avatar Oct 24 '24 12:10 potiuk

Solved in https://github.com/apache/airflow/pull/43272

eladkal avatar Nov 26 '24 18:11 eladkal