airflow.models.xcom deprecations removed

[dirrao]

airflow.models.xcom deprecations removed

[dirrao]

@potiuk / @eladkal, We have updated Xcoms provider tests. Provider tests are failing on earlier Airflow versions. Do we need to add airflow version condition-based checks? WDYT?

[potiuk]

Yes. We are running providers with previous Airflow versions - so ideally we should have them succeeded with older airflows as well. Likely a test_compat could be added to make xcom_push test work on both - see the contributing_docs for back-compatibility tests and tests/test_utils/compat.py

[dirrao]

@potiuk / @uranusjr Provider backward compatibility test is failing. Ideally, it should pass. Something nontrivial to me. Can someone help me with this?

[potiuk]

Looks like mock_context in conftest.py should be modified to accept xcom_push with execution_date when Airflow < 3.0. Likely could be done by adding **kwargs to the xcom_push method and checking if execution_date is not passed when Airflow 3 (but passed when Airflow < 3)

[dirrao]

Looks like mock_context in conftest.py should be modified to accept xcom_push with execution_date when Airflow < 3.0. Likely could be done by adding **kwargs to the xcom_push method and checking if execution_date is not passed when Airflow 3 (but passed when Airflow < 3)

Finally all the tests are passing except one unrelated test. Looks good to me.