airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Support the unpack operator in signature

Open jabbera opened this issue 1 year ago • 8 comments

Support the unpack operator in operator signature.

Closes: #41286


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

jabbera avatar Aug 07 '24 19:08 jabbera

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Aug 07 '24 19:08 boring-cyborg[bot]

The changes look good — great work for a first PR! 😉 I think better add tests here, let me know what you think.

romsharon98 avatar Aug 08 '24 15:08 romsharon98

I think better add tests here, let me know what you think.

@romsharon98 test_operator_helpers doesn't have the create_ti function/infrastructure that's available in test_python. I could put the determine method under test directly in test_operator_helpers instead of actually executing a task if that's what you mean?

jabbera avatar Aug 08 '24 17:08 jabbera

I think better add tests here, let me know what you think.

@romsharon98 test_operator_helpers doesn't have the create_ti function/infrastructure that's available in test_python. I could put the determine method under test directly in test_operator_helpers instead of actually executing a task if that's what you mean?

Yes, this is what I meant.

romsharon98 avatar Aug 10 '24 13:08 romsharon98

@romsharon98 Sorry for the delay. This is all set. Branch rebased.

jabbera avatar Aug 19 '24 15:08 jabbera

changes looks good! static tests failed, better working with pre-commit and prevent those errors.

romsharon98 avatar Aug 19 '24 21:08 romsharon98

static tests failed, better working with pre-commit and prevent those errors.

All set!

jabbera avatar Aug 20 '24 13:08 jabbera

Hi, is there anything else needed for this PR? Thanks!

jabbera avatar Aug 28 '24 00:08 jabbera

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar Aug 30 '24 06:08 boring-cyborg[bot]