airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Adding Code Coverage webserver code and Fix TypeError and AttributeError in Views.py

Open andyjianzhou opened this issue 1 year ago • 3 comments

Improved code coverage in these following spaces in both Webserver and Core:

Run: Core: python scripts/cov/core_coverage.py Run: Webserver: python scripts/cov/www_coverage.py

airflow/models/taskmap.py - Increased from 82% to 100% Coverage airflow/www/widgets.py - Increased from 79% to 100% Coverage airflow/www/views.py - Help increase Coverage from 78% to 85% Related: #35127


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

andyjianzhou avatar Jun 15 '24 05:06 andyjianzhou

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Jun 15 '24 05:06 boring-cyborg[bot]

You’ll need to revert the whitespace changes, they cause the linter to fail.

uranusjr avatar Jun 18 '24 06:06 uranusjr

You’ll need to revert the whitespace changes, they cause the linter to fail.

Will do thanks!

andyjianzhou avatar Jun 18 '24 06:06 andyjianzhou

@potiuk a test that seems to be completely unrelated to these changes is failing. Any recommendation here?

RNHTTR avatar Jul 22 '24 20:07 RNHTTR

@potiuk a test that seems to be completely unrelated to these changes is failing. Any recommendation here?

I re-run it (next time you can do it as well -> top-right re-run button with "re-run failed tests` dropdown.. Mssql server on linux has a tenedency to suddenly stop working and takes a lot of memory (one of the reasons we dumped mssql as backend as it was making our tests way flakier that they should be.

potiuk avatar Jul 23 '24 23:07 potiuk

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar Jul 24 '24 22:07 boring-cyborg[bot]