airflow
airflow copied to clipboard
update: remove RFC3896 `conn_type` warning
Remove warning about underscores in conn_type.
When secrets backend is initially loaded using a URI a Connection object is created using the URI (e.g. Vault) part of which involves normalizing conn_type by replacing dashes with underscores (see Connection._normalize_conn_type). Then when the connection is saved to secret cache (see Connection.get_connection_from_secrets) the connection with a normalized conn_type is transformed back into a URI which causes the RFC3896 warning related to underscores appearing in conn_type.
For example, a google-cloud-platform connection in Vault defined as a URI (where conn_type is google-cloud-platform) will generate this warning about underscores in the conn_type when referenced by an Airflow component.
{
"conn_uri": "google-cloud-platform:..."
}
Another option could be to move this warning to Connection._normalize_conn_type.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
- In case of a new feature add useful documentation (in docstrings or in
docs/directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it. - Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the Airflow Coding style.
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.