airflow icon indicating copy to clipboard operation
airflow copied to clipboard

SageMakerTransformOperator does not deduplicate model name

Open mxuan0 opened this issue 1 year ago • 2 comments

Apache Airflow Provider(s)

amazon

Versions of Apache Airflow Providers

8.7.1

Apache Airflow version

2.7.2

Operating System

amazon linux AMI

Deployment

Amazon (AWS) MWAA

Deployment details

No response

What happened

The SageMakerTransformOperator deduplicates job name before creating the job, but does not deduplicate the model name before creating the model. Upon retry, the operator would fail due to model already exist error.

What you think should happen instead

The operator should apply the same behavior (fail or add timestamp) to both the job name and the model name.

How to reproduce

create a DAG containing a SageMakerTransformOperator step. In the operator config, fix both ModelName and TransformJobName. In airflow UI, run the task until completion in airflow once, and the run the same task for the second time by "clear task".

Anything else

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

mxuan0 avatar May 08 '24 21:05 mxuan0

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

boring-cyborg[bot] avatar May 08 '24 21:05 boring-cyborg[bot]

Hi! I would like to work on this issue after triage!

mateuslatrova avatar May 08 '24 23:05 mateuslatrova