airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Published 20 hours ago • verified publisher icon apache

Allow FTPHook to change port number

Open VelmiraPetkova opened this issue 1 year ago • 3 comments

Allow FTPHook to use a custom FTP port number

closes: #39308

VelmiraPetkova avatar May 07 '24 15:05 VelmiraPetkova

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar May 07 '24 15:05 boring-cyborg[bot]

Yes, I'll do the test case over the weekend.

VelmiraPetkova avatar May 09 '24 20:05 VelmiraPetkova

I did some tests and fixed a tiny bug, when no port is supplied.

VelmiraPetkova avatar May 14 '24 19:05 VelmiraPetkova

@VelmiraPetkova can you please fix static checks?

eladkal avatar May 26 '24 05:05 eladkal

Sorry for the delay. I updated the PR. Could you please take a look? Thank you!

VelmiraPetkova avatar May 26 '24 12:05 VelmiraPetkova

The failing integration test case is a flake - mssql does not have enough time to start. This has been fixed in #39866

potiuk avatar May 27 '24 11:05 potiuk

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar May 27 '24 11:05 boring-cyborg[bot]